Ready

mirendev/runtime#1448

This fixes the problem the ticket describes, and I didn't find anything that should block it.

The readiness probe dials 127.0.0.1:443 without SNI. Before this change, Controller.GetCertificate returned no SNI provided for those handshakes. Now it serves the same self-signed fallback the autocert path already uses: autotls.LoadOrGenerateFallbackCert, from the same <dataPath>/certs directory. Because the fix lives on the server side, an old probe passes against a new server. That's what lets affected clusters upgrade onto this release without --no-auto-rollback.

What I checked

The change is small and narrow, and it follows a pattern the autocert ingress already uses in production. I'm comfortable recommending approval without a separate human code review.


Verdict: ready

Data

{
  "owner": "mirendev",
  "repo": "runtime",
  "number": 1448,
  "verdict": "ready",
  "approve": true,
  "event": "approve",
  "summary": "This fixes the problem the ticket describes, and I didn't find anything that should block it.\n\nThe readiness probe dials `127.0.0.1:443` without SNI. Before this change, `Controller.GetCertificate` returned `no SNI provided` for those handshakes. Now it serves the same self-signed fallback the autocert path already uses: `autotls.LoadOrGenerateFallbackCert`, from the same `\u003cdataPath\u003e/certs` directory. Because the fix lives on the server side, an old probe passes against a new server. That's what lets affected clusters upgrade onto this release without `--no-auto-rollback`.\n\n**What I checked**\n- **Ordering and races.** `initializeLego` sets `fallbackCert` before the account and registration steps, which hit the network. In `components/coordinate/workload_control.go`, `dnsController.Init(ctx)` finishes before the controller becomes `c.certProvider`, and `autotls.ServeTLSWithController` wires `certProvider.GetCertificate` straight into the `tls.Config`. So no TLS handshake can read the field while it's being written, and the field never changes afterwards.\n- **File collisions.** The fallback is written as `fallback-cert.pem` and `fallback-key.pem`. `loadExistingCerts` only picks up `*.crt` files with a matching `.key`, so the fallback can't end up in the domain cache or get pushed into the shared store as an `acme/certificates/...` entry.\n- **Exposure.** An SNI-less client now gets a self-signed cert whose only names are localhost and loopback, the same thing it gets on the autocert ingress. Handshakes that carry an SNI for an unknown name still fail as they did before.\n- **The test.** `probe_test.go` drives the real `HealthProber` over a TLS listener whose only certificate source is `controller.GetCertificate`. The comment explains why it avoids `StartTLS`: that would add a static certificate and bypass the path under test. The first subtest reproduces the failure and the second shows the fix. It builds the `Controller` directly instead of going through `initializeLego`, which makes sense since that path needs a live ACME provider. The only untested piece is the three-line wiring, and it mirrors `AutocertController.Init`.\n\nThe change is small and narrow, and it follows a pattern the autocert ingress already uses in production. I'm comfortable recommending approval without a separate human code review.",
  "posted_to_pr": true,
  "draft": true,
  "head_sha": "ccbc0fedfafb11a9ce9eaed71e2a1babd1f87966"
}