This is a focused, intentional GA promotion: flip distributedrunners from false → true in both the canonical source-of-truth (features.yaml) and the generated file (labs.gen.go), and add a test that pins that expectation. I read through all three files and the surrounding call sites before reaching a verdict.
The change is correct. The IsEnabled path in labs.gen.go (lines 118–124) has a two-tier lookup: first the enabledFeatures map, then featureDefaults. This means the new default takes effect even in the CLI path (cli.go) where labs.Init is only called when MIREN_LABS is non-empty — DistributedRunners() will correctly return true without an explicit Init, because the fallback reads straight from featureDefaults. I confirmed this explicitly.
The test is meaningful. TestDistributedRunnersEnabledByDefault calls Reset() to clear any prior state, then Init(nil, nil) with no flags, and asserts DistributedRunners() returns true. That's exactly the path a fresh server startup takes when no MIREN_LABS env var is set.
Existing disablement still works. The Init flag parser still accepts -distributedrunners (and -all) to let operators opt out. The existing tests (TestAllKeywordWithExclusion, TestNegativeAllDisablesAll) cover this. Nothing in the PR touches that logic.
One small observation worth flagging: the .iso/peers.yml fixture and CLAUDE.md both still configure MIREN_LABS=distributedrunners explicitly to opt the test environment in. With the feature now on by default, those explicit flags are a no-op rather than wrong — but they create mild noise by implying the feature still needs opting in. This is purely cosmetic and doesn't affect correctness, so I'm not blocking on it.
This is a clean, well-scoped GA graduation. Ready to graduate to human review (noting it's still a draft).
distributedrunners is on by default, MIREN_LABS=distributedrunners here is a no-op rather than wrong. Worth removing so the file doesn't imply the feature still needs an explicit opt-in — but this isn't a blocker.Verdict: ready
{
"owner": "mirendev",
"repo": "runtime",
"number": 971,
"verdict": "ready",
"event": "comment",
"summary": "This is a focused, intentional GA promotion: flip `distributedrunners` from `false` → `true` in both the canonical source-of-truth (`features.yaml`) and the generated file (`labs.gen.go`), and add a test that pins that expectation. I read through all three files and the surrounding call sites before reaching a verdict.\n\n**The change is correct.** The `IsEnabled` path in `labs.gen.go` (lines 118–124) has a two-tier lookup: first the `enabledFeatures` map, then `featureDefaults`. This means the new default takes effect even in the CLI path (`cli.go`) where `labs.Init` is only called when `MIREN_LABS` is non-empty — `DistributedRunners()` will correctly return `true` without an explicit `Init`, because the fallback reads straight from `featureDefaults`. I confirmed this explicitly.\n\n**The test is meaningful.** `TestDistributedRunnersEnabledByDefault` calls `Reset()` to clear any prior state, then `Init(nil, nil)` with no flags, and asserts `DistributedRunners()` returns `true`. That's exactly the path a fresh server startup takes when no `MIREN_LABS` env var is set.\n\n**Existing disablement still works.** The `Init` flag parser still accepts `-distributedrunners` (and `-all`) to let operators opt out. The existing tests (`TestAllKeywordWithExclusion`, `TestNegativeAllDisablesAll`) cover this. Nothing in the PR touches that logic.\n\n**One small observation worth flagging:** the `.iso/peers.yml` fixture and `CLAUDE.md` both still configure `MIREN_LABS=distributedrunners` explicitly to opt the test environment _in_. With the feature now on by default, those explicit flags are a no-op rather than wrong — but they create mild noise by implying the feature still needs opting in. This is purely cosmetic and doesn't affect correctness, so I'm not blocking on it.\n\nThis is a clean, well-scoped GA graduation. Ready to graduate to human review (noting it's still a draft).",
"comments": [
{
"path": ".iso/peers.yml",
"line": 15,
"side": "RIGHT",
"body": "Now that `distributedrunners` is on by default, `MIREN_LABS=distributedrunners` here is a no-op rather than wrong. Worth removing so the file doesn't imply the feature still needs an explicit opt-in — but this isn't a blocker."
}
],
"posted_to_pr": true,
"draft": true
}